The following document contains the results of PMD
| Violation | Line |
|---|---|
| Parameter 'file' is not assigned and could be declared final | 47 |
| Parameter 'username' is not assigned and could be declared final | 63 |
| Parameter 'password' is not assigned and could be declared final | 70 |
| Parameter 'username' is not assigned and could be declared final | 70 |
| Parameter 'routeID' is not assigned and could be declared final | 77 |
| Parameter 'coord' is not assigned and could be declared final | 77 |
| Parameter 'routeID' is not assigned and could be declared final | 84 |
| Parameter 'coord' is not assigned and could be declared final | 84 |
| Parameter 'userID' is not assigned and could be declared final | 92 |
| Parameter 'description' is not assigned and could be declared final | 92 |
| Parameter 'publicRoute' is not assigned and could be declared final | 92 |
| Parameter 'username' is not assigned and could be declared final | 99 |
| Parameter 'routeId' is not assigned and could be declared final | 106 |
| Parameter 'routeID' is not assigned and could be declared final | 113 |
| Parameter 'userId' is not assigned and could be declared final | 127 |
| Parameter 'routeID' is not assigned and could be declared final | 134 |
| Parameter 'visible' is not assigned and could be declared final | 134 |
| Parameter 'lock' is not assigned and could be declared final | 141 |
| Parameter 'routeID' is not assigned and could be declared final | 141 |
| Parameter 'userId' is not assigned and could be declared final | 145 |
| Parameter 'message' is not assigned and could be declared final | 153 |
| Local variable could be declared final | 154 |
| Local variable could be declared final | 161 |
| System.out.print is used | 166 |
| Avoid printStackTrace(); use a logger call instead. | 167 |
| Violation | Line |
|---|---|
| Local variable could be declared final | 55 |
| Avoid printStackTrace(); use a logger call instead. | 60 |
| Avoid printStackTrace(); use a logger call instead. | 62 |
| Parameter 'username' is not assigned and could be declared final | 71 |
| Local variable could be declared final | 72 |
| Local variable could be declared final | 75 - 76 |
| Local variable could be declared final | 78 |
| Local variable could be declared final | 79 |
| Avoid printStackTrace(); use a logger call instead. | 91 |
| Parameter 'user' is not assigned and could be declared final | 100 |
| Parameter 'pass' is not assigned and could be declared final | 100 |
| Local variable could be declared final | 101 |
| Local variable could be declared final | 106 - 107 |
| Local variable could be declared final | 109 |
| Local variable could be declared final | 110 |
| Avoid printStackTrace(); use a logger call instead. | 123 |
| Parameter 'routeID' is not assigned and could be declared final | 132 |
| Parameter 'coord' is not assigned and could be declared final | 132 |
| Local variable could be declared final | 133 |
| Local variable could be declared final | 136 - 141 |
| The String literal "', '" appears 5 times in this file; the first occurrence is on line 138 | 138 |
| Local variable could be declared final | 143 |
| Avoid printStackTrace(); use a logger call instead. | 155 |
| Parameter 'routeID' is not assigned and could be declared final | 163 |
| Parameter 'coords' is not assigned and could be declared final | 163 |
| Local variable could be declared final | 164 |
| Local variable could be declared final | 166 |
| Local variable could be declared final | 168 - 173 |
| Avoid printStackTrace(); use a logger call instead. | 184 |
| Local variable could be declared final | 193 |
| Local variable could be declared final | 196 |
| Local variable could be declared final | 199 |
| Local variable could be declared final | 200 |
| Local variable could be declared final | 201 |
| Avoid instantiating new objects inside loops | 206 |
| Avoid printStackTrace(); use a logger call instead. | 213 |
| Parameter 'userId' is not assigned and could be declared final | 225 |
| Local variable could be declared final | 226 |
| Local variable could be declared final | 231 - 232 |
| Local variable could be declared final | 233 |
| Local variable could be declared final | 234 |
| Local variable could be declared final | 237 |
| Avoid instantiating new objects inside loops | 238 |
| Avoid printStackTrace(); use a logger call instead. | 245 |
| Parameter 'userId' is not assigned and could be declared final | 254 |
| Parameter 'description' is not assigned and could be declared final | 254 |
| Parameter 'publicRoute' is not assigned and could be declared final | 255 |
| Local variable could be declared final | 258 |
| Local variable could be declared final | 261 - 263 |
| Local variable could be declared final | 265 |
| Local variable could be declared final | 268 - 269 |
| Local variable could be declared final | 271 |
| Avoid printStackTrace(); use a logger call instead. | 284 |
| Parameter 'username' is not assigned and could be declared final | 293 |
| Local variable could be declared final | 294 |
| Local variable could be declared final | 295 |
| Local variable could be declared final | 296 |
| Local variable could be declared final | 299 - 304 |
| Local variable could be declared final | 306 |
| Local variable could be declared final | 307 |
| Local variable could be declared final | 310 |
| Local variable could be declared final | 311 |
| Local variable could be declared final | 312 |
| Local variable could be declared final | 313 |
| Local variable could be declared final | 314 |
| Local variable could be declared final | 315 - 319 |
| Local variable could be declared final | 321 |
| Local variable could be declared final | 322 |
| Avoid instantiating new objects inside loops | 329 - 330 |
| Avoid printStackTrace(); use a logger call instead. | 337 |
| Parameter 'routeID' is not assigned and could be declared final | 346 |
| Local variable could be declared final | 347 |
| Local variable could be declared final | 348 |
| Local variable could be declared final | 352 - 354 |
| The String literal "WHERE rId = '" appears 5 times in this file; the first occurrence is on line 354 | 354 |
| Local variable could be declared final | 356 |
| Local variable could be declared final | 357 |
| Avoid instantiating new objects inside loops | 360 - 361 |
| Avoid printStackTrace(); use a logger call instead. | 369 |
| Parameter 'routeID' is not assigned and could be declared final | 378 |
| Parameter 'visible' is not assigned and could be declared final | 378 |
| Local variable could be declared final | 379 |
| Local variable could be declared final | 382 - 384 |
| Local variable could be declared final | 386 |
| Avoid printStackTrace(); use a logger call instead. | 394 |
| Parameter 'lock' is not assigned and could be declared final | 402 |
| Parameter 'routeID' is not assigned and could be declared final | 402 |
| Local variable could be declared final | 403 |
| Local variable could be declared final | 406 - 408 |
| Local variable could be declared final | 410 |
| Avoid printStackTrace(); use a logger call instead. | 418 |
| Parameter 'message' is not assigned and could be declared final | 422 |
| Parameter 'routeId' is not assigned and could be declared final | 433 |
| Local variable could be declared final | 436 |
| Local variable could be declared final | 439 - 442 |
| Local variable could be declared final | 444 |
| Local variable could be declared final | 445 |
| Local variable could be declared final | 448 |
| Local variable could be declared final | 449 |
| Local variable could be declared final | 450 |
| Local variable could be declared final | 451 |
| Local variable could be declared final | 453 - 457 |
| Local variable could be declared final | 459 |
| Local variable could be declared final | 460 |
| Avoid instantiating new objects inside loops | 466 - 467 |
| Avoid printStackTrace(); use a logger call instead. | 476 |
| Violation | Line |
|---|---|
| Parameter 'key' is not assigned and could be declared final | 38 |
| Violation | Line |
|---|---|
| Parameter 'username' is not assigned and could be declared final | 126 |
| Local variable could be declared final | 127 |
| Local variable could be declared final | 135 |
| Parameter 'out' is not assigned and could be declared final | 154 |
| Parameter 'message' is not assigned and could be declared final | 154 |
| Avoid printStackTrace(); use a logger call instead. | 159 |
| Parameter 'message' is not assigned and could be declared final | 168 |
| Parameter 'out' is not assigned and could be declared final | 178 |
| Parameter 'message' is not assigned and could be declared final | 178 |
| Parameter 'message' is not assigned and could be declared final | 187 |
| Avoid printStackTrace(); use a logger call instead. | 216 |
| Avoid printStackTrace(); use a logger call instead. | 228 |
| Violation | Line |
|---|---|
| Avoid printStackTrace(); use a logger call instead. | 85 |
| Avoid returning from a finally block | 88 |
| Avoid printStackTrace(); use a logger call instead. | 98 |
| Local variable could be declared final | 111 |
| Local variable could be declared final | 161 |
| Local variable could be declared final | 174 |
| Parameter 'message' is not assigned and could be declared final | 186 |
| Violation | Line |
|---|---|
| The String literal "Server" appears 10 times in this file; the first occurrence is on line 75 | 75 |
| System.out.print is used | 88 |
| Avoid printStackTrace(); use a logger call instead. | 89 |
| Avoid instantiating new objects inside loops | 118 |
| Parameter 'gpsHandler' is not assigned and could be declared final | 168 |
| Avoid printStackTrace(); use a logger call instead. | 239 |
| System.out.print is used | 312 |
| Local variable could be declared final | 319 |
| Local variable could be declared final | 321 |
| System.out.print is used | 326 |
| Avoid printStackTrace(); use a logger call instead. | 327 |
| Violation | Line |
|---|---|
| Parameter 'message' is not assigned and could be declared final | 76 |
| Local variable could be declared final | 90 |
| Local variable could be declared final | 91 |
| Local variable could be declared final | 92 |
| Local variable could be declared final | 93 - 94 |
| Local variable could be declared final | 104 |
| Avoid printStackTrace(); use a logger call instead. | 137 |
| Parameter 'coord' is not assigned and could be declared final | 149 |
| Parameter 'size' is not assigned and could be declared final | 161 |
| System.out.print is used | 162 |
| Local variable could be declared final | 165 |
| Local variable could be declared final | 167 |
| Local variable could be declared final | 169 |
| Local variable could be declared final | 171 |
| Local variable could be declared final | 172 |
| Local variable could be declared final | 173 |
| Avoid instantiating new objects inside loops | 176 - 177 |
| Avoid printStackTrace(); use a logger call instead. | 186 |
| Parameter 'coord' is not assigned and could be declared final | 246 |
| Parameter 'coords' is not assigned and could be declared final | 257 |
| Parameter 'listener' is not assigned and could be declared final | 275 |
| Parameter 'listener' is not assigned and could be declared final | 285 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.util.zip.GZIPOutputStream' | 27 |
| Avoid using if statements without curly braces | 58 - 59 |
| Parameter 'message' is not assigned and could be declared final | 67 |
| Local variable could be declared final | 68 |
| Local variable could be declared final | 81 |
| Local variable could be declared final | 96 |
| Local variable could be declared final | 99 |
| Parameter 'coord' is not assigned and could be declared final | 127 |
| Parameter 'coords' is not assigned and could be declared final | 133 |
| Local variable could be declared final | 134 |
| Local variable could be declared final | 139 |
| Local variable could be declared final | 140 |
| Local variable could be declared final | 141 |
| Parameter 'gpsHandler' is not assigned and could be declared final | 155 |
| Parameter 'gpsHandler' is not assigned and could be declared final | 165 |
| Local variable could be declared final | 176 |
| Local variable could be declared final | 177 |
| Parameter 'routeId' is not assigned and could be declared final | 191 |
| Avoid using if statements without curly braces | 199 - 200 |
| Local variable could be declared final | 206 |
| Local variable could be declared final | 208 |
| Avoid using if...else statements without curly braces | 216 |
| Avoid using if...else statements without curly braces | 218 |
| Violation | Line |
|---|---|
| Parameter 'y' is not assigned and could be declared final | 51 |
| Parameter 'x' is not assigned and could be declared final | 51 |
| Parameter 'p' is not assigned and could be declared final | 56 |
| Violation | Line |
|---|---|
| Parameter 'fileName' is not assigned and could be declared final | 43 |
| String.indexOf(char) is faster than String.indexOf(String) | 45 |
| Local variable could be declared final | 45 |
| Parameter 'file' is not assigned and could be declared final | 60 |
| Parameter 'file' is not assigned and could be declared final | 72 |
| Parameter 'decimals' is not assigned and could be declared final | 85 |
| Parameter 'number' is not assigned and could be declared final | 85 |
| Local variable could be declared final | 86 |
| Parameter 'decimals' is not assigned and could be declared final | 100 |
| Parameter 'number' is not assigned and could be declared final | 100 |
| Parameter 'dateString' is not assigned and could be declared final | 109 |
| Parameter 'datePattern' is not assigned and could be declared final | 113 |
| Parameter 'dateString' is not assigned and could be declared final | 113 |
| Local variable could be declared final | 114 |
| Parameter 'date' is not assigned and could be declared final | 126 |
| Parameter 'datePattern' is not assigned and could be declared final | 130 |
| Parameter 'date' is not assigned and could be declared final | 130 |
| Parameter 'date1' is not assigned and could be declared final | 134 |
| Parameter 'date2' is not assigned and could be declared final | 134 |
| Local variable could be declared final | 135 |
| Local variable could be declared final | 136 |
| Local variable could be declared final | 141 |
| Local variable could be declared final | 142 |
| Local variable could be declared final | 143 |
| Local variable could be declared final | 144 |
| Local variable could be declared final | 145 |
| Local variable could be declared final | 146 |
| Local variable could be declared final | 147 |
| Parameter 'string' is not assigned and could be declared final | 189 |
| Parameter 'string' is not assigned and could be declared final | 204 |
| Parameter 'def' is not assigned and could be declared final | 204 |
| Local variable could be declared final | 206 |
| Violation | Line |
|---|---|
| Parameter 'out' is not assigned and could be declared final | 157 |
| Parameter 'flush' is not assigned and could be declared final | 157 |
| Parameter 'message' is not assigned and could be declared final | 157 |
| Parameter 'out' is not assigned and could be declared final | 177 |
| Parameter 'message' is not assigned and could be declared final | 177 |
| Parameter 'message' is not assigned and could be declared final | 190 |
| Local variable could be declared final | 191 |
| Parameter 'msgDelim' is not assigned and could be declared final | 210 |
| Parameter 'message' is not assigned and could be declared final | 211 |
| Parameter 'message' is not assigned and could be declared final | 240 |
| Violation | Line |
|---|---|
| Local variable could be declared final | 49 |
| Local variable could be declared final | 52 |
| Parameter 'decimals' is not assigned and could be declared final | 86 |
| Local variable could be declared final | 94 |
| Local variable could be declared final | 97 |
| Local variable could be declared final | 100 |
| Local variable could be declared final | 102 |
| Local variable could be declared final | 103 |
| Violation | Line |
|---|---|
| Avoid importing anything from the package java.lang | 22 |
| Local variable could be declared final | 179 |
| Local variable could be declared final | 209 |
| Avoid using if...else statements without curly braces | 214 |
| Avoid using if...else statements without curly braces | 216 |
| Local variable could be declared final | 227 |
| Local variable could be declared final | 272 |
| Local variable could be declared final | 275 |
| Local variable could be declared final | 294 |
| Local variable could be declared final | 297 |
| Local variable could be declared final | 300 |
| Local variable could be declared final | 315 |
| Local variable could be declared final | 319 |
| Local variable could be declared final | 322 |
| Local variable could be declared final | 340 |
| Local variable could be declared final | 344 |
| Local variable could be declared final | 347 |
| Local variable could be declared final | 418 |
| Local variable could be declared final | 589 |
| Local variable could be declared final | 597 |
| Avoid empty if statements | 603 |
| System.out.print is used | 637 |
| Violation | Line |
|---|---|
| Parameter 'i' is not assigned and could be declared final | 96 |
| Returning 'ellipsoids' may expose an internal array | 105 |
| Violation | Line |
|---|---|
| Parameter 'active' is not assigned and could be declared final | 102 |
| Parameter 'visibility' is not assigned and could be declared final | 115 |
| Violation | Line |
|---|---|
| A signature (constructor or method) shouldn't have Exception in throws declaration | 28 |
| Parameter 'args' is not assigned and could be declared final | 28 |
| System.out.print is used | 29 |
| System.out.print is used | 32 |
| Local variable could be declared final | 33 |
| System.out.print is used | 35 |
| System.out.print is used | 38 |
| Avoid unused local variables such as 'con' | 39 |
| Local variable could be declared final | 39 - 40 |
| Violation | Line |
|---|---|
| Local variable could be declared final | 39 |
| Local variable could be declared final | 41 - 42 |
| Avoid unused local variables such as 'inBuff' | 46 |
| Local variable could be declared final | 46 - 47 |
| Local variable could be declared final | 56 |
| System.out.print is used | 59 |
| Local variable could be declared final | 60 |
| System.out.print is used | 67 |
| System.out.print is used | 68 |
| Avoid printStackTrace(); use a logger call instead. | 73 |
| Violation | Line |
|---|---|
| Parameter 'port' is not assigned and could be declared final | 37 |
| Local variable could be declared final | 39 |
| Local variable could be declared final | 40 |
| Avoid unused local variables such as 'compressed' | 45 |
| Local variable could be declared final | 45 - 47 |
| Local variable could be declared final | 49 |
| Local variable could be declared final | 50 |
| Parameter 'args' is not assigned and could be declared final | 73 |
| Violation | Line |
|---|---|
| Local variable could be declared final | 40 |
| Avoid instantiating new objects inside loops | 42 |
| Avoid printStackTrace(); use a logger call instead. | 45 |
| Parameter 'args' is not assigned and could be declared final | 49 |
| Violation | Line |
|---|---|
| Parameter 'obj' is not assigned and could be declared final | 56 |
| Local variable could be declared final | 57 |
| Local variable could be declared final | 60 - 61 |
| Parameter 'args' is not assigned and could be declared final | 77 |
| Parameter 'proxy' is not assigned and could be declared final | 77 |
| Parameter 'method' is not assigned and could be declared final | 77 |
| Avoid using if statements without curly braces | 79 - 80 |
| Parameter 'state' is not assigned and could be declared final | 130 |
| Violation | Line |
|---|---|
| Parameter 'args' is not assigned and could be declared final | 49 |
| Parameter 'proxy' is not assigned and could be declared final | 49 |
| Parameter 'method' is not assigned and could be declared final | 49 |
| These nested if statements could be combined | 53 - 57 |
| System.out.print is used | 56 |
| Parameter 'obj' is not assigned and could be declared final | 63 |
| Local variable could be declared final | 64 |
| Local variable could be declared final | 67 - 69 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 94 - 95 |
| Avoid using if statements without curly braces | 102 - 103 |
| Local variable could be declared final | 121 |
| Parameter 'len' is not assigned and could be declared final | 162 |
| Parameter 'b' is not assigned and could be declared final | 162 |
| Parameter 'off' is not assigned and could be declared final | 162 |
| Avoid using if...else statements without curly braces | 171 |
| Avoid using if...else statements without curly braces | 173 |
| Avoid using if statements without curly braces | 175 - 176 |
| Local variable could be declared final | 181 |
| Violation | Line |
|---|---|
| Local variable could be declared final | 106 |
| Parameter 'b' is not assigned and could be declared final | 129 |
| Parameter 'b' is not assigned and could be declared final | 137 |
| Local variable could be declared final | 139 |
| Violation | Line |
|---|---|
| Parameter 'obj' is not assigned and could be declared final | 31 |
| Parameter 'm' is not assigned and could be declared final | 40 |
| Parameter 'args' is not assigned and could be declared final | 40 |
| Parameter 'proxy' is not assigned and could be declared final | 40 |
| System.out.print is used | 44 |
| Avoid throwing raw exception types | 49 |
| System.out.print is used | 52 |
| Violation | Line |
|---|---|
| Parameter 'args' is not assigned and could be declared final | 39 |
| Local variable could be declared final | 55 |
| Local variable could be declared final | 56 |
| Local variable could be declared final | 65 |
| Avoid instantiating new objects inside loops | 65 |
| Local variable could be declared final | 66 |
| Avoid instantiating new objects inside loops | 66 |
| Avoid using if...else statements without curly braces | 70 |
| Avoid using if...else statements without curly braces | 72 |
| Local variable could be declared final | 73 |
| Avoid instantiating new objects inside loops | 73 |
| Avoid using if...else statements without curly braces | 75 |
| System.out.print is used | 75 |
| Avoid using if...else statements without curly braces | 77 |
| System.out.print is used | 77 |
| Avoid empty catch blocks | 82 |
| System.out.print is used | 83 |
| Avoid unused private methods such as 'oldieDecNmeaDecTest()' | 86 |
| Local variable could be declared final | 87 - 88 |
| System.out.print is used | 91 |
| The String literal ") = " appears 8 times in this file; the first occurrence is on line 91 | 91 |
| System.out.print is used | 93 |
| Local variable could be declared final | 100 - 101 |
| System.out.print is used | 104 |
| System.out.print is used | 106 |
| Local variable could be declared final | 113 |
| System.out.print is used | 116 |
| System.out.print is used | 118 |
| Local variable could be declared final | 128 - 129 |
| System.out.print is used | 137 |
| System.out.print is used | 139 |
| Local variable could be declared final | 158 |
| System.out.print is used | 161 |
| System.out.print is used | 167 |
| System.out.print is used | 168 |
| Local variable could be declared final | 170 |
| Local variable could be declared final | 172 |
| Local variable could be declared final | 174 |
| System.out.print is used | 179 |
| Local variable could be declared final | 186 |
| System.out.print is used | 190 |
| Local variable could be declared final | 207 |
| Local variable could be declared final | 209 |
| System.out.print is used | 210 |
| Local variable could be declared final | 212 |
| System.out.print is used | 217 |
| Local variable could be declared final | 237 |
| System.out.print is used | 238 |
| Violation | Line |
|---|---|
| Parameter 'args' is not assigned and could be declared final | 27 |
| Avoid unused local variables such as 'f4' | 36 |
| Local variable could be declared final | 36 |
| Avoid unused local variables such as 'f5' | 42 |
| Local variable could be declared final | 42 |
| Local variable could be declared final | 47 |
| Local variable could be declared final | 48 |
| Local variable could be declared final | 51 - 52 |
| System.out.print is used | 54 |
| System.out.print is used | 55 |
| System.out.print is used | 64 |
| Avoid unused private methods such as 'breakUp(double)' | 74 |
| Local variable could be declared final | 75 |
| Local variable could be declared final | 76 |
| Local variable could be declared final | 88 |
| Local variable could be declared final | 94 |
| Local variable could be declared final | 105 |
| Local variable could be declared final | 115 |
| Violation | Line |
|---|---|
| System.out.print is used | 38 |
| Parameter 'g' is not assigned and could be declared final | 63 |
| System.out.print is used | 87 |
| System.out.print is used | 113 |
| Violation | Line |
|---|---|
| Parameter 'args' is not assigned and could be declared final | 37 |
| Local variable could be declared final | 54 |
| Avoid printStackTrace(); use a logger call instead. | 57 |
| Avoid printStackTrace(); use a logger call instead. | 59 |
| Local variable could be declared final | 69 |
| Local variable could be declared final | 71 |
| Local variable could be declared final | 74 |
| Local variable could be declared final | 77 - 79 |
| Local variable could be declared final | 81 |
| System.out.print is used | 82 |
| Avoid printStackTrace(); use a logger call instead. | 87 |
| Local variable could be declared final | 90 |
| System.out.print is used | 91 |
| Local variable could be declared final | 99 |
| Local variable could be declared final | 102 |
| Local variable could be declared final | 104 |
| Local variable could be declared final | 107 |
| Local variable could be declared final | 109 - 111 |
| Local variable could be declared final | 113 |
| Avoid instantiating new objects inside loops | 129 |
| System.out.print is used | 132 |
| Local variable could be declared final | 136 - 140 |
| Avoid printStackTrace(); use a logger call instead. | 148 |
| Local variable could be declared final | 151 |
| System.out.print is used | 152 |
| Local variable could be declared final | 159 |
| Local variable could be declared final | 163 |
| Local variable could be declared final | 165 |
| Local variable could be declared final | 168 |
| Local variable could be declared final | 170 - 171 |
| Local variable could be declared final | 173 |
| Avoid instantiating new objects inside loops | 206 |
| System.out.print is used | 210 |
| Local variable could be declared final | 214 - 218 |
| Avoid printStackTrace(); use a logger call instead. | 226 |
| Local variable could be declared final | 229 |
| System.out.print is used | 230 |
| Violation | Line |
|---|---|
| Parameter 'user' is not assigned and could be declared final | 42 |
| Parameter 'pass' is not assigned and could be declared final | 42 |
| Parameter 'coord' is not assigned and could be declared final | 51 |
| Parameter 'coordBuffer' is not assigned and could be declared final | 62 |
| Local variable could be declared final | 71 |
| Parameter 'description' is not assigned and could be declared final | 120 |
| Parameter 'route' is not assigned and could be declared final | 125 |
| Parameter 'routes' is not assigned and could be declared final | 129 |
| Parameter 'listener' is not assigned and could be declared final | 143 |
| Parameter 'listener' is not assigned and could be declared final | 151 |
| Parameter 'message' is not assigned and could be declared final | 159 |
| Local variable could be declared final | 160 |
| Local variable could be declared final | 173 |
| Local variable could be declared final | 176 |
| Local variable could be declared final | 177 |
| Local variable could be declared final | 178 |
| Local variable could be declared final | 179 |
| Local variable could be declared final | 180 |
| Local variable could be declared final | 181 |
| Local variable could be declared final | 182 - 183 |
| Avoid instantiating new objects inside loops | 182 - 183 |
| System.out.print is used | 196 |
| Avoid printStackTrace(); use a logger call instead. | 197 |
| Parameter 'routeId' is not assigned and could be declared final | 210 |
| Violation | Line |
|---|---|
| Parameter 'user' is not assigned and could be declared final | 44 |
| Parameter 'pass' is not assigned and could be declared final | 44 |
| Parameter 'listener' is not assigned and could be declared final | 52 |
| Parameter 'listener' is not assigned and could be declared final | 60 |
| Parameter 'userId' is not assigned and could be declared final | 71 |
| Parameter 'route' is not assigned and could be declared final | 78 |
| Parameter 'route' is not assigned and could be declared final | 91 |
| Parameter 'routeId' is not assigned and could be declared final | 110 |
| Parameter 'coord' is not assigned and could be declared final | 110 |
| Parameter 'coords' is not assigned and could be declared final | 128 |
| Parameter 'users' is not assigned and could be declared final | 143 |
| Parameter 'user' is not assigned and could be declared final | 157 |
| Parameter 'routeId' is not assigned and could be declared final | 173 |
| Parameter 'coords' is not assigned and could be declared final | 173 |
| Parameter 'routes' is not assigned and could be declared final | 188 |
| Parameter 'message' is not assigned and could be declared final | 202 |
| System.out.print is used | 211 |
| Local variable could be declared final | 238 |
| Avoid instantiating new objects inside loops | 244 - 245 |
| Local variable could be declared final | 251 |
| Local variable could be declared final | 253 |
| Local variable could be declared final | 254 |
| Avoid instantiating new objects inside loops | 255 |
| Local variable could be declared final | 260 |
| Local variable could be declared final | 265 |
| Local variable could be declared final | 288 - 289 |
| Avoid instantiating new objects inside loops | 288 - 289 |
| Local variable could be declared final | 298 |
| Local variable could be declared final | 312 |
| Local variable could be declared final | 313 |
| Local variable could be declared final | 314 |
| Local variable could be declared final | 315 |
| Local variable could be declared final | 316 |
| Local variable could be declared final | 317 - 318 |
| Avoid instantiating new objects inside loops | 317 - 318 |
| System.out.print is used | 336 |
| System.out.print is used | 340 |
| Avoid printStackTrace(); use a logger call instead. | 341 |
| Violation | Line |
|---|---|
| Parameter 'routes' is not assigned and could be declared final | 48 |
| Parameter 'message' is not assigned and could be declared final | 53 |
| Parameter 'e' is not assigned and could be declared final | 58 |
| Parameter 'state' is not assigned and could be declared final | 63 |
| Parameter 'routeId' is not assigned and could be declared final | 68 |
| Violation | Line |
|---|---|
| Parameter 'state' is not assigned and could be declared final | 50 |
| Parameter 'message' is not assigned and could be declared final | 55 |
| Parameter 'e' is not assigned and could be declared final | 60 |
| Parameter 'routeId' is not assigned and could be declared final | 65 |
| Parameter 'coordinate' is not assigned and could be declared final | 65 |
| Parameter 'coords' is not assigned and could be declared final | 70 |
| Parameter 'routes' is not assigned and could be declared final | 75 |
| Parameter 'routeId' is not assigned and could be declared final | 80 |
| Parameter 'coordinates' is not assigned and could be declared final | 80 |
| Parameter 'routeId' is not assigned and could be declared final | 85 |
| Parameter 'state' is not assigned and could be declared final | 85 |
| Parameter 'users' is not assigned and could be declared final | 90 |
| Parameter 'user' is not assigned and could be declared final | 95 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'triptracker.core.Protocol' | 37 |
| Parameter 'host' is not assigned and could be declared final | 78 |
| Parameter 'port' is not assigned and could be declared final | 78 |
| Local variable could be declared final | 103 |
| Parameter 'user' is not assigned and could be declared final | 118 |
| Parameter 'type' is not assigned and could be declared final | 118 |
| Parameter 'pass' is not assigned and could be declared final | 118 |
| Parameter 'route' is not assigned and could be declared final | 134 |
| Parameter 'username' is not assigned and could be declared final | 142 |
| Parameter 'message' is not assigned and could be declared final | 152 |
| System.out.print is used | 158 |
| Parameter 'listener' is not assigned and could be declared final | 269 |
| Parameter 'listener' is not assigned and could be declared final | 278 |
| Parameter 'listener' is not assigned and could be declared final | 289 |
| Parameter 'exception' is not assigned and could be declared final | 290 |
| System.out.print is used | 291 |
| Avoid printStackTrace(); use a logger call instead. | 292 |
| Parameter 'exception' is not assigned and could be declared final | 304 |
| Parameter 'message' is not assigned and could be declared final | 320 |
| Parameter 'state' is not assigned and could be declared final | 339 |
| Avoid printStackTrace(); use a logger call instead. | 370 |
| Avoid empty catch blocks | 377 - 379 |
| Parameter 'host' is not assigned and could be declared final | 402 |
| Parameter 'port' is not assigned and could be declared final | 422 |
| Violation | Line |
|---|---|
| Parameter 'sentence' is not assigned and could be declared final | 79 |
| Avoid empty if statements | 89 |
| Local variable could be declared final | 94 |
| Avoid using if statements without curly braces | 125 - 174 |
| These nested if statements could be combined | 130 - 174 |
| Avoid using if statements without curly braces | 130 - 174 |
| These nested if statements could be combined | 135 - 174 |
| Avoid using if statements without curly braces | 135 - 174 |
| These nested if statements could be combined | 142 - 174 |
| Avoid using if statements without curly braces | 142 - 174 |
| These nested if statements could be combined | 154 - 174 |
| Avoid empty if statements | 173 |
| Parameter 'index' is not assigned and could be declared final | 179 |
| Parameter 'fieldName' is not assigned and could be declared final | 183 |
| Parameter 'ignoreChecksum' is not assigned and could be declared final | 215 |
| Violation | Line |
|---|---|
| Parameter 'coord' is not assigned and could be declared final | 71 |
| Local variable could be declared final | 72 - 73 |
| Avoid using if statements without curly braces | 76 - 77 |
| Local variable could be declared final | 80 |
| Local variable could be declared final | 92 |
| Local variable could be declared final | 95 |
| System.out.print is used | 100 |
| System.out.print is used | 111 |
| Avoid using if...else statements without curly braces | 112 |
| System.out.print is used | 114 |
| Avoid using if...else statements without curly braces | 119 |
| Parameter 'file' is not assigned and could be declared final | 128 |
| Parameter 'data' is not assigned and could be declared final | 138 |
| Parameter 'user' is not assigned and could be declared final | 149 |
| Parameter 'pass' is not assigned and could be declared final | 149 |
| System.out.print is used | 160 |
| Parameter 'listener' is not assigned and could be declared final | 168 |
| Parameter 'listener' is not assigned and could be declared final | 177 |
| Parameter 'listener' is not assigned and could be declared final | 186 |
| Parameter 'listener' is not assigned and could be declared final | 194 |
| Parameter 'port' is not assigned and could be declared final | 227 |
| System.out.print is used | 228 |
| Parameter 'compression' is not assigned and could be declared final | 237 |
| Parameter 'inte' is not assigned and could be declared final | 255 |
| Avoid using if statements without curly braces | 290 - 291 |
| Avoid using if...else statements without curly braces | 319 |
| Avoid using if...else statements without curly braces | 321 |
| Avoid using if...else statements without curly braces | 331 |
| Avoid using if...else statements without curly braces | 333 |
| System.out.print is used | 342 |
| Avoid empty if statements | 346 |
| System.out.print is used | 352 |
| System.out.print is used | 356 |
| System.out.print is used | 367 |
| Parameter 'routeDesc' is not assigned and could be declared final | 385 |
| Parameter 'user' is not assigned and could be declared final | 394 |
| Parameter 'route' is not assigned and could be declared final | 412 |
| Parameter 'route' is not assigned and could be declared final | 422 |
| Parameter 'route' is not assigned and could be declared final | 432 |
| Local variable could be declared final | 433 |
| Parameter 'route' is not assigned and could be declared final | 444 |
| System.out.print is used | 445 |
| System.out.print is used | 447 |
| System.out.print is used | 486 |
| System.out.print is used | 519 |
| Parameter 'enable' is not assigned and could be declared final | 565 |
| Parameter 'host' is not assigned and could be declared final | 578 |
| Parameter 'port' is not assigned and could be declared final | 582 |
| Violation | Line |
|---|---|
| Parameter 'port' is not assigned and could be declared final | 87 |
| Local variable could be declared final | 93 |
| System.out.print is used | 96 |
| Avoid instantiating new objects inside loops | 127 - 128 |
| Avoid instantiating new objects inside loops | 130 |
| System.out.print is used | 178 |
| Local variable could be declared final | 214 - 215 |
| Avoid throwing null pointer exceptions | 218 |
| Local variable could be declared final | 256 |
| Local variable could be declared final | 257 |
| Parameter 'listener' is not assigned and could be declared final | 289 |
| Parameter 'exception' is not assigned and could be declared final | 290 |
| System.out.print is used | 291 |
| Avoid printStackTrace(); use a logger call instead. | 292 |
| Parameter 'connected' is not assigned and could be declared final | 303 |
| Parameter 'listener' is not assigned and could be declared final | 318 |
| Parameter 'listener' is not assigned and could be declared final | 327 |
| Parameter 'event' is not assigned and could be declared final | 335 |
| System.out.print is used | 338 |
| System.out.print is used | 341 |
| System.out.print is used | 344 |
| System.out.print is used | 350 |
| System.out.print is used | 353 |
| System.out.print is used | 356 |
| System.out.print is used | 359 |
| System.out.print is used | 362 |
| System.out.print is used | 365 |
| Parameter 'state' is not assigned and could be declared final | 371 |
| System.out.print is used | 391 |
| System.out.print is used | 419 |
| System.out.print is used | 428 |
| Parameter 'ioe' is not assigned and could be declared final | 453 |
| Violation | Line |
|---|---|
| Parameter 'event' is not assigned and could be declared final | 45 |
| Violation | Line |
|---|---|
| Parameter 'event' is not assigned and could be declared final | 47 |
| Local variable could be declared final | 65 |
| System.out.print is used | 68 |
| Avoid using if statements without curly braces | 81 - 82 |
| Avoid using if statements without curly braces | 84 - 88 |
| Avoid using if statements without curly braces | 95 - 96 |
| Avoid using if statements without curly braces | 104 - 105 |
| System.out.print is used | 123 |
| These nested if statements could be combined | 128 - 131 |
| Avoid using if statements without curly braces | 134 - 135 |
| Violation | Line |
|---|---|
| Parameter 'listener' is not assigned and could be declared final | 138 |
| Parameter 'routes' is not assigned and could be declared final | 165 |
| System.out.print is used | 166 |
| Parameter 'rId' is not assigned and could be declared final | 171 |
| Local variable could be declared final | 173 |
| Parameter 'routes' is not assigned and could be declared final | 179 |
| Parameter 'msg' is not assigned and could be declared final | 197 |
| Local variable could be declared final | 207 |
| Local variable could be declared final | 208 - 212 |
| Parameter 'info' is not assigned and could be declared final | 222 |
| Parameter 'head' is not assigned and could be declared final | 222 |
| Violation | Line |
|---|---|
| Parameter 'args' is not assigned and could be declared final | 32 |
| System.out.print is used | 33 |
| System.out.print is used | 34 |
| Local variable could be declared final | 36 |
| Local variable could be declared final | 38 |
| Local variable could be declared final | 40 |
| System.out.print is used | 44 |
| Local variable could be declared final | 48 |
| Local variable could be declared final | 49 |
| Violation | Line |
|---|---|
| Parameter 'listener' is not assigned and could be declared final | 175 |
| Parameter 'listener' is not assigned and could be declared final | 184 |
| Parameter 'listener' is not assigned and could be declared final | 193 |
| Parameter 'listener' is not assigned and could be declared final | 202 |
| Parameter 'coord' is not assigned and could be declared final | 220 |
| Local variable could be declared final | 228 |
| System.out.print is used | 262 |
| Parameter 'icon' is not assigned and could be declared final | 274 |
| Parameter 'error' is not assigned and could be declared final | 274 |
| Parameter 'heading' is not assigned and could be declared final | 274 |
| Local variable could be declared final | 284 |
| Local variable could be declared final | 285 |
| Parameter 'status' is not assigned and could be declared final | 308 |
| Parameter 'lat' is not assigned and could be declared final | 326 |
| Parameter 'lon' is not assigned and could be declared final | 326 |
| Parameter 'update' is not assigned and could be declared final | 336 |
| Parameter 'state' is not assigned and could be declared final | 340 |
| System.out.print is used | 344 |
| System.out.print is used | 347 |
| System.out.print is used | 351 |
| System.out.print is used | 355 |
| Parameter 'connected' is not assigned and could be declared final | 360 |
| Parameter 'listener' is not assigned and could be declared final | 367 |
| Parameter 'text' is not assigned and could be declared final | 376 |
| Parameter 'text' is not assigned and could be declared final | 385 |
| Parameter 'error' is not assigned and could be declared final | 402 |
| Parameter 'heading' is not assigned and could be declared final | 402 |
| Local variable could be declared final | 459 |
| Local variable could be declared final | 460 - 463 |
| Parameter 'route' is not assigned and could be declared final | 472 |
| Parameter 'state' is not assigned and could be declared final | 477 |
| Parameter 'e' is not assigned and could be declared final | 542 |
| System.out.print is used | 544 |
| Parameter 'dist' is not assigned and could be declared final | 552 |
| Violation | Line |
|---|---|
| Parameter 'event' is not assigned and could be declared final | 45 |
| Avoid printStackTrace(); use a logger call instead. | 70 |
| Violation | Line |
|---|---|
| The String literal "tab hfill" appears 4 times in this file; the first occurrence is on line 113 | 113 |
| Parameter 'listener' is not assigned and could be declared final | 144 |
| Parameter 'msg' is not assigned and could be declared final | 186 |
| Parameter 'state' is not assigned and could be declared final | 194 |
| System.out.print is used | 204 |
| Parameter 'warning' is not assigned and could be declared final | 241 |
| Parameter 'heading' is not assigned and could be declared final | 241 |
| Parameter 'enable' is not assigned and could be declared final | 257 |
| Violation | Line |
|---|---|
| Parameter 'event' is not assigned and could be declared final | 64 |
| System.out.print is used | 84 |
| Avoid using if...else statements without curly braces | 87 |
| Avoid using if...else statements without curly braces | 89 |
| Parameter 'event' is not assigned and could be declared final | 103 |
| System.out.print is used | 106 |
| Parameter 'e' is not assigned and could be declared final | 115 |
| Avoid using if statements without curly braces | 176 - 177 |
| Avoid using if statements without curly braces | 184 - 185 |
| System.out.print is used | 200 |
| Avoid using if statements without curly braces | 208 - 209 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 41 - 42 |
| Parameter 'event' is not assigned and could be declared final | 50 |
| Local variable could be declared final | 51 |
| Avoid using if statements without curly braces | 81 - 82 |
| Violation | Line |
|---|---|
| The String literal "center" appears 5 times in this file; the first occurrence is on line 106 | 106 |
| Parameter 'listener' is not assigned and could be declared final | 135 |
| Local variable could be declared final | 156 |
| System.out.print is used | 159 |
| Parameter 'msg' is not assigned and could be declared final | 196 |
| Violation | Line |
|---|---|
| Parameter 'width' is not assigned and could be declared final | 46 |
| Parameter 'height' is not assigned and could be declared final | 46 |
| Violation | Line |
|---|---|
| Parameter 'minY' is not assigned and could be declared final | 141 |
| Parameter 'minX' is not assigned and could be declared final | 141 |
| Parameter 'maxX' is not assigned and could be declared final | 142 |
| Parameter 'maxY' is not assigned and could be declared final | 142 |
| Local variable could be declared final | 155 |
| System.out.print is used | 173 |
| Avoid using if...else statements without curly braces | 177 |
| Local variable could be declared final | 187 |
| Parameter 'layers' is not assigned and could be declared final | 225 |
| Parameter 'layerName' is not assigned and could be declared final | 229 |
| Parameter 'layerName' is not assigned and could be declared final | 233 |
| Parameter 'layerName' is not assigned and could be declared final | 237 |
| Parameter 'styles' is not assigned and could be declared final | 244 |
| Parameter 'styleName' is not assigned and could be declared final | 248 |
| Parameter 'styleName' is not assigned and could be declared final | 252 |
| Parameter 'styleName' is not assigned and could be declared final | 256 |
| Parameter 'imageFormat' is not assigned and could be declared final | 268 |
| Parameter 'providerUrl' is not assigned and could be declared final | 276 |
| Parameter 'srs' is not assigned and could be declared final | 284 |
| Parameter 'bgColor' is not assigned and could be declared final | 292 |
| Parameter 'transparent' is not assigned and could be declared final | 300 |
| Violation | Line |
|---|---|
| Parameter 'mat2' is not assigned and could be declared final | 148 |
| Parameter 'mat1' is not assigned and could be declared final | 148 |
| Avoid using if statements without curly braces | 152 - 153 |
| Parameter 'factor' is not assigned and could be declared final | 175 |
| Parameter 'matrix' is not assigned and could be declared final | 175 |
| Parameter 'matrices' is not assigned and could be declared final | 209 |
| Avoid using if statements without curly braces | 216 - 218 |
| Parameter 'matrices' is not assigned and could be declared final | 235 |
| Local variable could be declared final | 236 - 237 |
| Avoid using if statements without curly braces | 242 - 244 |
| Parameter 'layout' is not assigned and could be declared final | 266 |
| Local variable could be declared final | 267 - 268 |
| Parameter 'mat' is not assigned and could be declared final | 284 |
| Parameter 'defaultValue' is not assigned and could be declared final | 285 |
| Local variable could be declared final | 286 - 287 |
| Local variable could be declared final | 288 |
| Local variable could be declared final | 289 |
| Parameter 'layout' is not assigned and could be declared final | 315 |
| Avoid using if statements without curly braces | 326 - 327 |
| Avoid using if statements without curly braces | 335 - 336 |
| Avoid using if statements without curly braces | 344 - 345 |
| Avoid using if statements without curly braces | 353 - 354 |
| Violation | Line |
|---|---|
| The user-supplied array 'matrix' is stored directly | 35 |
| Parameter 'matrix' is not assigned and could be declared final | 35 |
| Returning 'mat' may expose an internal array | 40 |
| Parameter 'i' is not assigned and could be declared final | 43 |
| Parameter 'value' is not assigned and could be declared final | 43 |
| Parameter 'j' is not assigned and could be declared final | 43 |
| Parameter 'i' is not assigned and could be declared final | 47 |
| Parameter 'j' is not assigned and could be declared final | 47 |
| Parameter 'dimension' is not assigned and could be declared final | 51 |
| Local variable could be declared final | 92 |
| Parameter 'o' is not assigned and could be declared final | 145 |
| System.out.print is used | 146 |
| Parameter 'o' is not assigned and could be declared final | 153 |
| Parameter 'forward' is not assigned and could be declared final | 163 |
| Violation | Line |
|---|---|
| Parameter 'minY' is not assigned and could be declared final | 43 |
| Parameter 'minX' is not assigned and could be declared final | 43 |
| Parameter 'maxX' is not assigned and could be declared final | 44 |
| Parameter 'maxY' is not assigned and could be declared final | 44 |
| Violation | Line |
|---|---|
| Parameter 'e' is not assigned and could be declared final | 57 |
| Parameter 'e' is not assigned and could be declared final | 67 |
| Parameter 'e' is not assigned and could be declared final | 80 |
| Parameter 'e' is not assigned and could be declared final | 98 |
| Avoid using if...else statements without curly braces | 105 |
| Parameter 'e' is not assigned and could be declared final | 111 |
| Parameter 'e' is not assigned and could be declared final | 117 |
| Parameter 'e' is not assigned and could be declared final | 123 |
| Parameter 'e' is not assigned and could be declared final | 129 |
| Violation | Line |
|---|---|
| Parameter 'click' is not assigned and could be declared final | 43 |
| Violation | Line |
|---|---|
| Parameter 'route' is not assigned and could be declared final | 82 |
| Parameter 'realtime' is not assigned and could be declared final | 82 |
| Parameter 'user' is not assigned and could be declared final | 88 |
| Parameter 'route' is not assigned and could be declared final | 88 |
| Parameter 'coordList' is not assigned and could be declared final | 100 |
| Parameter 'nr' is not assigned and could be declared final | 104 |
| Parameter 'map' is not assigned and could be declared final | 104 |
| Parameter 'dot' is not assigned and could be declared final | 104 |
| Parameter 'thick' is not assigned and could be declared final | 104 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'javax.swing.ImageIcon' | 35 |
| Violation | Line |
|---|---|
| Parameter 'e' is not assigned and could be declared final | 46 |
| Local variable could be declared final | 47 |
| Local variable could be declared final | 48 |
| Violation | Line |
|---|---|
| Parameter 'listener' is not assigned and could be declared final | 105 |
| Parameter 'msg' is not assigned and could be declared final | 125 |
| Parameter 'e' is not assigned and could be declared final | 133 |
| Parameter 'state' is not assigned and could be declared final | 141 |
| Violation | Line |
|---|---|
| Avoid unused constructor parameters such as 'model' | 34 - 44 |
| Parameter 'e' is not assigned and could be declared final | 47 |
| Parameter 'e' is not assigned and could be declared final | 53 |
| Parameter 'arg0' is not assigned and could be declared final | 59 |
| Parameter 'arg0' is not assigned and could be declared final | 62 |
| Parameter 'arg0' is not assigned and could be declared final | 63 |
| Parameter 'arg0' is not assigned and could be declared final | 64 |
| Parameter 'arg0' is not assigned and could be declared final | 65 |
| Parameter 'arg0' is not assigned and could be declared final | 69 |
| Parameter 'arg0' is not assigned and could be declared final | 72 |
| Parameter 'arg0' is not assigned and could be declared final | 73 |
| Parameter 'arg0' is not assigned and could be declared final | 74 |
| Parameter 'arg0' is not assigned and could be declared final | 75 |
| Parameter 'arg0' is not assigned and could be declared final | 80 |
| Avoid using if...else statements without curly braces | 82 |
| Avoid using if...else statements without curly braces | 84 |
| Avoid using if...else statements without curly braces | 86 |
| Parameter 'arg0' is not assigned and could be declared final | 91 |
| Violation | Line |
|---|---|
| Parameter 'form' is not assigned and could be declared final | 48 |
| Parameter 'form' is not assigned and could be declared final | 60 |
| Parameter 'form' is not assigned and could be declared final | 72 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'thread' | 18 |
| Parameter 'x' is not assigned and could be declared final | 44 |
| Local variable could be declared final | 65 |
| Local variable could be declared final | 79 |
| Local variable could be declared final | 96 |
| Local variable could be declared final | 141 |