PMD Results

The following document contains the results of PMD

Files

triptracker/server/persistence/PersistenceAdapter.java

ViolationLine
Parameter 'file' is not assigned and could be declared final47
Parameter 'username' is not assigned and could be declared final63
Parameter 'password' is not assigned and could be declared final70
Parameter 'username' is not assigned and could be declared final70
Parameter 'routeID' is not assigned and could be declared final77
Parameter 'coord' is not assigned and could be declared final77
Parameter 'routeID' is not assigned and could be declared final84
Parameter 'coord' is not assigned and could be declared final84
Parameter 'userID' is not assigned and could be declared final92
Parameter 'description' is not assigned and could be declared final92
Parameter 'publicRoute' is not assigned and could be declared final92
Parameter 'username' is not assigned and could be declared final99
Parameter 'routeId' is not assigned and could be declared final106
Parameter 'routeID' is not assigned and could be declared final113
Parameter 'userId' is not assigned and could be declared final127
Parameter 'routeID' is not assigned and could be declared final134
Parameter 'visible' is not assigned and could be declared final134
Parameter 'lock' is not assigned and could be declared final141
Parameter 'routeID' is not assigned and could be declared final141
Parameter 'userId' is not assigned and could be declared final145
Parameter 'message' is not assigned and could be declared final153
Local variable could be declared final154
Local variable could be declared final161
System.out.print is used166
Avoid printStackTrace(); use a logger call instead.167

triptracker/server/persistence/MySqlDB.java

ViolationLine
Local variable could be declared final55
Avoid printStackTrace(); use a logger call instead.60
Avoid printStackTrace(); use a logger call instead.62
Parameter 'username' is not assigned and could be declared final71
Local variable could be declared final72
Local variable could be declared final75 - 76
Local variable could be declared final78
Local variable could be declared final79
Avoid printStackTrace(); use a logger call instead.91
Parameter 'user' is not assigned and could be declared final100
Parameter 'pass' is not assigned and could be declared final100
Local variable could be declared final101
Local variable could be declared final106 - 107
Local variable could be declared final109
Local variable could be declared final110
Avoid printStackTrace(); use a logger call instead.123
Parameter 'routeID' is not assigned and could be declared final132
Parameter 'coord' is not assigned and could be declared final132
Local variable could be declared final133
Local variable could be declared final136 - 141
The String literal "', '" appears 5 times in this file; the first occurrence is on line 138138
Local variable could be declared final143
Avoid printStackTrace(); use a logger call instead.155
Parameter 'routeID' is not assigned and could be declared final163
Parameter 'coords' is not assigned and could be declared final163
Local variable could be declared final164
Local variable could be declared final166
Local variable could be declared final168 - 173
Avoid printStackTrace(); use a logger call instead.184
Local variable could be declared final193
Local variable could be declared final196
Local variable could be declared final199
Local variable could be declared final200
Local variable could be declared final201
Avoid instantiating new objects inside loops206
Avoid printStackTrace(); use a logger call instead.213
Parameter 'userId' is not assigned and could be declared final225
Local variable could be declared final226
Local variable could be declared final231 - 232
Local variable could be declared final233
Local variable could be declared final234
Local variable could be declared final237
Avoid instantiating new objects inside loops238
Avoid printStackTrace(); use a logger call instead.245
Parameter 'userId' is not assigned and could be declared final254
Parameter 'description' is not assigned and could be declared final254
Parameter 'publicRoute' is not assigned and could be declared final255
Local variable could be declared final258
Local variable could be declared final261 - 263
Local variable could be declared final265
Local variable could be declared final268 - 269
Local variable could be declared final271
Avoid printStackTrace(); use a logger call instead.284
Parameter 'username' is not assigned and could be declared final293
Local variable could be declared final294
Local variable could be declared final295
Local variable could be declared final296
Local variable could be declared final299 - 304
Local variable could be declared final306
Local variable could be declared final307
Local variable could be declared final310
Local variable could be declared final311
Local variable could be declared final312
Local variable could be declared final313
Local variable could be declared final314
Local variable could be declared final315 - 319
Local variable could be declared final321
Local variable could be declared final322
Avoid instantiating new objects inside loops329 - 330
Avoid printStackTrace(); use a logger call instead.337
Parameter 'routeID' is not assigned and could be declared final346
Local variable could be declared final347
Local variable could be declared final348
Local variable could be declared final352 - 354
The String literal "WHERE rId = '" appears 5 times in this file; the first occurrence is on line 354354
Local variable could be declared final356
Local variable could be declared final357
Avoid instantiating new objects inside loops360 - 361
Avoid printStackTrace(); use a logger call instead.369
Parameter 'routeID' is not assigned and could be declared final378
Parameter 'visible' is not assigned and could be declared final378
Local variable could be declared final379
Local variable could be declared final382 - 384
Local variable could be declared final386
Avoid printStackTrace(); use a logger call instead.394
Parameter 'lock' is not assigned and could be declared final402
Parameter 'routeID' is not assigned and could be declared final402
Local variable could be declared final403
Local variable could be declared final406 - 408
Local variable could be declared final410
Avoid printStackTrace(); use a logger call instead.418
Parameter 'message' is not assigned and could be declared final422
Parameter 'routeId' is not assigned and could be declared final433
Local variable could be declared final436
Local variable could be declared final439 - 442
Local variable could be declared final444
Local variable could be declared final445
Local variable could be declared final448
Local variable could be declared final449
Local variable could be declared final450
Local variable could be declared final451
Local variable could be declared final453 - 457
Local variable could be declared final459
Local variable could be declared final460
Avoid instantiating new objects inside loops466 - 467
Avoid printStackTrace(); use a logger call instead.476

triptracker/server/persistence/Properties.java

ViolationLine
Parameter 'key' is not assigned and could be declared final38

triptracker/server/ClientHandler.java

ViolationLine
Parameter 'username' is not assigned and could be declared final126
Local variable could be declared final127
Local variable could be declared final135
Parameter 'out' is not assigned and could be declared final154
Parameter 'message' is not assigned and could be declared final154
Avoid printStackTrace(); use a logger call instead.159
Parameter 'message' is not assigned and could be declared final168
Parameter 'out' is not assigned and could be declared final178
Parameter 'message' is not assigned and could be declared final178
Parameter 'message' is not assigned and could be declared final187
Avoid printStackTrace(); use a logger call instead.216
Avoid printStackTrace(); use a logger call instead.228

triptracker/server/CheckThread.java

ViolationLine
Avoid printStackTrace(); use a logger call instead.85
Avoid returning from a finally block88
Avoid printStackTrace(); use a logger call instead.98
Local variable could be declared final111
Local variable could be declared final161
Local variable could be declared final174
Parameter 'message' is not assigned and could be declared final186

triptracker/server/Server.java

ViolationLine
The String literal "Server" appears 10 times in this file; the first occurrence is on line 7575
System.out.print is used88
Avoid printStackTrace(); use a logger call instead.89
Avoid instantiating new objects inside loops118
Parameter 'gpsHandler' is not assigned and could be declared final168
Avoid printStackTrace(); use a logger call instead.239
System.out.print is used312
Local variable could be declared final319
Local variable could be declared final321
System.out.print is used326
Avoid printStackTrace(); use a logger call instead.327

triptracker/server/GPSHandler.java

ViolationLine
Parameter 'message' is not assigned and could be declared final76
Local variable could be declared final90
Local variable could be declared final91
Local variable could be declared final92
Local variable could be declared final93 - 94
Local variable could be declared final104
Avoid printStackTrace(); use a logger call instead.137
Parameter 'coord' is not assigned and could be declared final149
Parameter 'size' is not assigned and could be declared final161
System.out.print is used162
Local variable could be declared final165
Local variable could be declared final167
Local variable could be declared final169
Local variable could be declared final171
Local variable could be declared final172
Local variable could be declared final173
Avoid instantiating new objects inside loops176 - 177
Avoid printStackTrace(); use a logger call instead.186
Parameter 'coord' is not assigned and could be declared final246
Parameter 'coords' is not assigned and could be declared final257
Parameter 'listener' is not assigned and could be declared final275
Parameter 'listener' is not assigned and could be declared final285

triptracker/server/MapHandler.java

ViolationLine
Avoid unused imports such as 'java.util.zip.GZIPOutputStream'27
Avoid using if statements without curly braces58 - 59
Parameter 'message' is not assigned and could be declared final67
Local variable could be declared final68
Local variable could be declared final81
Local variable could be declared final96
Local variable could be declared final99
Parameter 'coord' is not assigned and could be declared final127
Parameter 'coords' is not assigned and could be declared final133
Local variable could be declared final134
Local variable could be declared final139
Local variable could be declared final140
Local variable could be declared final141
Parameter 'gpsHandler' is not assigned and could be declared final155
Parameter 'gpsHandler' is not assigned and could be declared final165
Local variable could be declared final176
Local variable could be declared final177
Parameter 'routeId' is not assigned and could be declared final191
Avoid using if statements without curly braces199 - 200
Local variable could be declared final206
Local variable could be declared final208
Avoid using if...else statements without curly braces216
Avoid using if...else statements without curly braces218

triptracker/core/BaseCoord.java

ViolationLine
Parameter 'y' is not assigned and could be declared final51
Parameter 'x' is not assigned and could be declared final51
Parameter 'p' is not assigned and could be declared final56

triptracker/core/Utils.java

ViolationLine
Parameter 'fileName' is not assigned and could be declared final43
String.indexOf(char) is faster than String.indexOf(String)45
Local variable could be declared final45
Parameter 'file' is not assigned and could be declared final60
Parameter 'file' is not assigned and could be declared final72
Parameter 'decimals' is not assigned and could be declared final85
Parameter 'number' is not assigned and could be declared final85
Local variable could be declared final86
Parameter 'decimals' is not assigned and could be declared final100
Parameter 'number' is not assigned and could be declared final100
Parameter 'dateString' is not assigned and could be declared final109
Parameter 'datePattern' is not assigned and could be declared final113
Parameter 'dateString' is not assigned and could be declared final113
Local variable could be declared final114
Parameter 'date' is not assigned and could be declared final126
Parameter 'datePattern' is not assigned and could be declared final130
Parameter 'date' is not assigned and could be declared final130
Parameter 'date1' is not assigned and could be declared final134
Parameter 'date2' is not assigned and could be declared final134
Local variable could be declared final135
Local variable could be declared final136
Local variable could be declared final141
Local variable could be declared final142
Local variable could be declared final143
Local variable could be declared final144
Local variable could be declared final145
Local variable could be declared final146
Local variable could be declared final147
Parameter 'string' is not assigned and could be declared final189
Parameter 'string' is not assigned and could be declared final204
Parameter 'def' is not assigned and could be declared final204
Local variable could be declared final206

triptracker/core/Protocol.java

ViolationLine
Parameter 'out' is not assigned and could be declared final157
Parameter 'flush' is not assigned and could be declared final157
Parameter 'message' is not assigned and could be declared final157
Parameter 'out' is not assigned and could be declared final177
Parameter 'message' is not assigned and could be declared final177
Parameter 'message' is not assigned and could be declared final190
Local variable could be declared final191
Parameter 'msgDelim' is not assigned and could be declared final210
Parameter 'message' is not assigned and could be declared final211
Parameter 'message' is not assigned and could be declared final240

triptracker/core/Sexagesimal.java

ViolationLine
Local variable could be declared final49
Local variable could be declared final52
Parameter 'decimals' is not assigned and could be declared final86
Local variable could be declared final94
Local variable could be declared final97
Local variable could be declared final100
Local variable could be declared final102
Local variable could be declared final103

triptracker/core/Coordinate.java

ViolationLine
Avoid importing anything from the package java.lang22
Local variable could be declared final179
Local variable could be declared final209
Avoid using if...else statements without curly braces214
Avoid using if...else statements without curly braces216
Local variable could be declared final227
Local variable could be declared final272
Local variable could be declared final275
Local variable could be declared final294
Local variable could be declared final297
Local variable could be declared final300
Local variable could be declared final315
Local variable could be declared final319
Local variable could be declared final322
Local variable could be declared final340
Local variable could be declared final344
Local variable could be declared final347
Local variable could be declared final418
Local variable could be declared final589
Local variable could be declared final597
Avoid empty if statements603
System.out.print is used637

triptracker/core/ReferenceEllipsoids.java

ViolationLine
Parameter 'i' is not assigned and could be declared final96
Returning 'ellipsoids' may expose an internal array105

triptracker/core/Route.java

ViolationLine
Parameter 'active' is not assigned and could be declared final102
Parameter 'visibility' is not assigned and could be declared final115

triptracker/testing/dbtest/DBTest.java

ViolationLine
A signature (constructor or method) shouldn't have Exception in throws declaration28
Parameter 'args' is not assigned and could be declared final28
System.out.print is used29
System.out.print is used32
Local variable could be declared final33
System.out.print is used35
System.out.print is used38
Avoid unused local variables such as 'con'39
Local variable could be declared final39 - 40

triptracker/testing/compress/ServerWorker.java

ViolationLine
Local variable could be declared final39
Local variable could be declared final41 - 42
Avoid unused local variables such as 'inBuff'46
Local variable could be declared final46 - 47
Local variable could be declared final56
System.out.print is used59
Local variable could be declared final60
System.out.print is used67
System.out.print is used68
Avoid printStackTrace(); use a logger call instead.73

triptracker/testing/compress/Demo.java

ViolationLine
Parameter 'port' is not assigned and could be declared final37
Local variable could be declared final39
Local variable could be declared final40
Avoid unused local variables such as 'compressed'45
Local variable could be declared final45 - 47
Local variable could be declared final49
Local variable could be declared final50
Parameter 'args' is not assigned and could be declared final73

triptracker/testing/compress/Server.java

ViolationLine
Local variable could be declared final40
Avoid instantiating new objects inside loops42
Avoid printStackTrace(); use a logger call instead.45
Parameter 'args' is not assigned and could be declared final49

triptracker/testing/compress/DebugProxy.java

ViolationLine
Parameter 'obj' is not assigned and could be declared final56
Local variable could be declared final57
Local variable could be declared final60 - 61
Parameter 'args' is not assigned and could be declared final77
Parameter 'proxy' is not assigned and could be declared final77
Parameter 'method' is not assigned and could be declared final77
Avoid using if statements without curly braces79 - 80
Parameter 'state' is not assigned and could be declared final130

triptracker/testing/compress/DBDebugProxy.java

ViolationLine
Parameter 'args' is not assigned and could be declared final49
Parameter 'proxy' is not assigned and could be declared final49
Parameter 'method' is not assigned and could be declared final49
These nested if statements could be combined53 - 57
System.out.print is used56
Parameter 'obj' is not assigned and could be declared final63
Local variable could be declared final64
Local variable could be declared final67 - 69

triptracker/testing/compress/CompressedBlockInputStream.java

ViolationLine
Avoid using if statements without curly braces94 - 95
Avoid using if statements without curly braces102 - 103
Local variable could be declared final121
Parameter 'len' is not assigned and could be declared final162
Parameter 'b' is not assigned and could be declared final162
Parameter 'off' is not assigned and could be declared final162
Avoid using if...else statements without curly braces171
Avoid using if...else statements without curly braces173
Avoid using if statements without curly braces175 - 176
Local variable could be declared final181

triptracker/testing/compress/CompressedBlockOutputStream.java

ViolationLine
Local variable could be declared final106
Parameter 'b' is not assigned and could be declared final129
Parameter 'b' is not assigned and could be declared final137
Local variable could be declared final139

triptracker/testing/DebugProxy.java

ViolationLine
Parameter 'obj' is not assigned and could be declared final31
Parameter 'm' is not assigned and could be declared final40
Parameter 'args' is not assigned and could be declared final40
Parameter 'proxy' is not assigned and could be declared final40
System.out.print is used44
Avoid throwing raw exception types49
System.out.print is used52

triptracker/testing/Test.java

ViolationLine
Parameter 'args' is not assigned and could be declared final39
Local variable could be declared final55
Local variable could be declared final56
Local variable could be declared final65
Avoid instantiating new objects inside loops65
Local variable could be declared final66
Avoid instantiating new objects inside loops66
Avoid using if...else statements without curly braces70
Avoid using if...else statements without curly braces72
Local variable could be declared final73
Avoid instantiating new objects inside loops73
Avoid using if...else statements without curly braces75
System.out.print is used75
Avoid using if...else statements without curly braces77
System.out.print is used77
Avoid empty catch blocks82
System.out.print is used83
Avoid unused private methods such as 'oldieDecNmeaDecTest()'86
Local variable could be declared final87 - 88
System.out.print is used91
The String literal ") = " appears 8 times in this file; the first occurrence is on line 9191
System.out.print is used93
Local variable could be declared final100 - 101
System.out.print is used104
System.out.print is used106
Local variable could be declared final113
System.out.print is used116
System.out.print is used118
Local variable could be declared final128 - 129
System.out.print is used137
System.out.print is used139
Local variable could be declared final158
System.out.print is used161
System.out.print is used167
System.out.print is used168
Local variable could be declared final170
Local variable could be declared final172
Local variable could be declared final174
System.out.print is used179
Local variable could be declared final186
System.out.print is used190
Local variable could be declared final207
Local variable could be declared final209
System.out.print is used210
Local variable could be declared final212
System.out.print is used217
Local variable could be declared final237
System.out.print is used238

triptracker/testing/UTMtest.java

ViolationLine
Parameter 'args' is not assigned and could be declared final27
Avoid unused local variables such as 'f4'36
Local variable could be declared final36
Avoid unused local variables such as 'f5'42
Local variable could be declared final42
Local variable could be declared final47
Local variable could be declared final48
Local variable could be declared final51 - 52
System.out.print is used54
System.out.print is used55
System.out.print is used64
Avoid unused private methods such as 'breakUp(double)'74
Local variable could be declared final75
Local variable could be declared final76
Local variable could be declared final88
Local variable could be declared final94
Local variable could be declared final105
Local variable could be declared final115

triptracker/testing/CoordinateTest.java

ViolationLine
System.out.print is used38
Parameter 'g' is not assigned and could be declared final63
System.out.print is used87
System.out.print is used113

triptracker/testing/DBConversion.java

ViolationLine
Parameter 'args' is not assigned and could be declared final37
Local variable could be declared final54
Avoid printStackTrace(); use a logger call instead.57
Avoid printStackTrace(); use a logger call instead.59
Local variable could be declared final69
Local variable could be declared final71
Local variable could be declared final74
Local variable could be declared final77 - 79
Local variable could be declared final81
System.out.print is used82
Avoid printStackTrace(); use a logger call instead.87
Local variable could be declared final90
System.out.print is used91
Local variable could be declared final99
Local variable could be declared final102
Local variable could be declared final104
Local variable could be declared final107
Local variable could be declared final109 - 111
Local variable could be declared final113
Avoid instantiating new objects inside loops129
System.out.print is used132
Local variable could be declared final136 - 140
Avoid printStackTrace(); use a logger call instead.148
Local variable could be declared final151
System.out.print is used152
Local variable could be declared final159
Local variable could be declared final163
Local variable could be declared final165
Local variable could be declared final168
Local variable could be declared final170 - 171
Local variable could be declared final173
Avoid instantiating new objects inside loops206
System.out.print is used210
Local variable could be declared final214 - 218
Avoid printStackTrace(); use a logger call instead.226
Local variable could be declared final229
System.out.print is used230

triptracker/client/net/GPSSocket.java

ViolationLine
Parameter 'user' is not assigned and could be declared final42
Parameter 'pass' is not assigned and could be declared final42
Parameter 'coord' is not assigned and could be declared final51
Parameter 'coordBuffer' is not assigned and could be declared final62
Local variable could be declared final71
Parameter 'description' is not assigned and could be declared final120
Parameter 'route' is not assigned and could be declared final125
Parameter 'routes' is not assigned and could be declared final129
Parameter 'listener' is not assigned and could be declared final143
Parameter 'listener' is not assigned and could be declared final151
Parameter 'message' is not assigned and could be declared final159
Local variable could be declared final160
Local variable could be declared final173
Local variable could be declared final176
Local variable could be declared final177
Local variable could be declared final178
Local variable could be declared final179
Local variable could be declared final180
Local variable could be declared final181
Local variable could be declared final182 - 183
Avoid instantiating new objects inside loops182 - 183
System.out.print is used196
Avoid printStackTrace(); use a logger call instead.197
Parameter 'routeId' is not assigned and could be declared final210

triptracker/client/net/MapSocket.java

ViolationLine
Parameter 'user' is not assigned and could be declared final44
Parameter 'pass' is not assigned and could be declared final44
Parameter 'listener' is not assigned and could be declared final52
Parameter 'listener' is not assigned and could be declared final60
Parameter 'userId' is not assigned and could be declared final71
Parameter 'route' is not assigned and could be declared final78
Parameter 'route' is not assigned and could be declared final91
Parameter 'routeId' is not assigned and could be declared final110
Parameter 'coord' is not assigned and could be declared final110
Parameter 'coords' is not assigned and could be declared final128
Parameter 'users' is not assigned and could be declared final143
Parameter 'user' is not assigned and could be declared final157
Parameter 'routeId' is not assigned and could be declared final173
Parameter 'coords' is not assigned and could be declared final173
Parameter 'routes' is not assigned and could be declared final188
Parameter 'message' is not assigned and could be declared final202
System.out.print is used211
Local variable could be declared final238
Avoid instantiating new objects inside loops244 - 245
Local variable could be declared final251
Local variable could be declared final253
Local variable could be declared final254
Avoid instantiating new objects inside loops255
Local variable could be declared final260
Local variable could be declared final265
Local variable could be declared final288 - 289
Avoid instantiating new objects inside loops288 - 289
Local variable could be declared final298
Local variable could be declared final312
Local variable could be declared final313
Local variable could be declared final314
Local variable could be declared final315
Local variable could be declared final316
Local variable could be declared final317 - 318
Avoid instantiating new objects inside loops317 - 318
System.out.print is used336
System.out.print is used340
Avoid printStackTrace(); use a logger call instead.341

triptracker/client/net/GPSSocketAdapter.java

ViolationLine
Parameter 'routes' is not assigned and could be declared final48
Parameter 'message' is not assigned and could be declared final53
Parameter 'e' is not assigned and could be declared final58
Parameter 'state' is not assigned and could be declared final63
Parameter 'routeId' is not assigned and could be declared final68

triptracker/client/net/MapSocketAdapter.java

ViolationLine
Parameter 'state' is not assigned and could be declared final50
Parameter 'message' is not assigned and could be declared final55
Parameter 'e' is not assigned and could be declared final60
Parameter 'routeId' is not assigned and could be declared final65
Parameter 'coordinate' is not assigned and could be declared final65
Parameter 'coords' is not assigned and could be declared final70
Parameter 'routes' is not assigned and could be declared final75
Parameter 'routeId' is not assigned and could be declared final80
Parameter 'coordinates' is not assigned and could be declared final80
Parameter 'routeId' is not assigned and could be declared final85
Parameter 'state' is not assigned and could be declared final85
Parameter 'users' is not assigned and could be declared final90
Parameter 'user' is not assigned and could be declared final95

triptracker/client/net/SocketConnection.java

ViolationLine
Avoid unused imports such as 'triptracker.core.Protocol'37
Parameter 'host' is not assigned and could be declared final78
Parameter 'port' is not assigned and could be declared final78
Local variable could be declared final103
Parameter 'user' is not assigned and could be declared final118
Parameter 'type' is not assigned and could be declared final118
Parameter 'pass' is not assigned and could be declared final118
Parameter 'route' is not assigned and could be declared final134
Parameter 'username' is not assigned and could be declared final142
Parameter 'message' is not assigned and could be declared final152
System.out.print is used158
Parameter 'listener' is not assigned and could be declared final269
Parameter 'listener' is not assigned and could be declared final278
Parameter 'listener' is not assigned and could be declared final289
Parameter 'exception' is not assigned and could be declared final290
System.out.print is used291
Avoid printStackTrace(); use a logger call instead.292
Parameter 'exception' is not assigned and could be declared final304
Parameter 'message' is not assigned and could be declared final320
Parameter 'state' is not assigned and could be declared final339
Avoid printStackTrace(); use a logger call instead.370
Avoid empty catch blocks377 - 379
Parameter 'host' is not assigned and could be declared final402
Parameter 'port' is not assigned and could be declared final422

triptracker/client/gps/core/NMEASentence.java

ViolationLine
Parameter 'sentence' is not assigned and could be declared final79
Avoid empty if statements89
Local variable could be declared final94
Avoid using if statements without curly braces125 - 174
These nested if statements could be combined130 - 174
Avoid using if statements without curly braces130 - 174
These nested if statements could be combined135 - 174
Avoid using if statements without curly braces135 - 174
These nested if statements could be combined142 - 174
Avoid using if statements without curly braces142 - 174
These nested if statements could be combined154 - 174
Avoid empty if statements173
Parameter 'index' is not assigned and could be declared final179
Parameter 'fieldName' is not assigned and could be declared final183
Parameter 'ignoreChecksum' is not assigned and could be declared final215

triptracker/client/gps/core/GPSClientModel.java

ViolationLine
Parameter 'coord' is not assigned and could be declared final71
Local variable could be declared final72 - 73
Avoid using if statements without curly braces76 - 77
Local variable could be declared final80
Local variable could be declared final92
Local variable could be declared final95
System.out.print is used100
System.out.print is used111
Avoid using if...else statements without curly braces112
System.out.print is used114
Avoid using if...else statements without curly braces119
Parameter 'file' is not assigned and could be declared final128
Parameter 'data' is not assigned and could be declared final138
Parameter 'user' is not assigned and could be declared final149
Parameter 'pass' is not assigned and could be declared final149
System.out.print is used160
Parameter 'listener' is not assigned and could be declared final168
Parameter 'listener' is not assigned and could be declared final177
Parameter 'listener' is not assigned and could be declared final186
Parameter 'listener' is not assigned and could be declared final194
Parameter 'port' is not assigned and could be declared final227
System.out.print is used228
Parameter 'compression' is not assigned and could be declared final237
Parameter 'inte' is not assigned and could be declared final255
Avoid using if statements without curly braces290 - 291
Avoid using if...else statements without curly braces319
Avoid using if...else statements without curly braces321
Avoid using if...else statements without curly braces331
Avoid using if...else statements without curly braces333
System.out.print is used342
Avoid empty if statements346
System.out.print is used352
System.out.print is used356
System.out.print is used367
Parameter 'routeDesc' is not assigned and could be declared final385
Parameter 'user' is not assigned and could be declared final394
Parameter 'route' is not assigned and could be declared final412
Parameter 'route' is not assigned and could be declared final422
Parameter 'route' is not assigned and could be declared final432
Local variable could be declared final433
Parameter 'route' is not assigned and could be declared final444
System.out.print is used445
System.out.print is used447
System.out.print is used486
System.out.print is used519
Parameter 'enable' is not assigned and could be declared final565
Parameter 'host' is not assigned and could be declared final578
Parameter 'port' is not assigned and could be declared final582

triptracker/client/gps/core/GPSConnection.java

ViolationLine
Parameter 'port' is not assigned and could be declared final87
Local variable could be declared final93
System.out.print is used96
Avoid instantiating new objects inside loops127 - 128
Avoid instantiating new objects inside loops130
System.out.print is used178
Local variable could be declared final214 - 215
Avoid throwing null pointer exceptions218
Local variable could be declared final256
Local variable could be declared final257
Parameter 'listener' is not assigned and could be declared final289
Parameter 'exception' is not assigned and could be declared final290
System.out.print is used291
Avoid printStackTrace(); use a logger call instead.292
Parameter 'connected' is not assigned and could be declared final303
Parameter 'listener' is not assigned and could be declared final318
Parameter 'listener' is not assigned and could be declared final327
Parameter 'event' is not assigned and could be declared final335
System.out.print is used338
System.out.print is used341
System.out.print is used344
System.out.print is used350
System.out.print is used353
System.out.print is used356
System.out.print is used359
System.out.print is used362
System.out.print is used365
Parameter 'state' is not assigned and could be declared final371
System.out.print is used391
System.out.print is used419
System.out.print is used428
Parameter 'ioe' is not assigned and could be declared final453

triptracker/client/gps/ui/GPSSettingsController.java

ViolationLine
Parameter 'event' is not assigned and could be declared final45

triptracker/client/gps/ui/RoutesController.java

ViolationLine
Parameter 'event' is not assigned and could be declared final47
Local variable could be declared final65
System.out.print is used68
Avoid using if statements without curly braces81 - 82
Avoid using if statements without curly braces84 - 88
Avoid using if statements without curly braces95 - 96
Avoid using if statements without curly braces104 - 105
System.out.print is used123
These nested if statements could be combined128 - 131
Avoid using if statements without curly braces134 - 135

triptracker/client/gps/ui/RoutesForm.java

ViolationLine
Parameter 'listener' is not assigned and could be declared final138
Parameter 'routes' is not assigned and could be declared final165
System.out.print is used166
Parameter 'rId' is not assigned and could be declared final171
Local variable could be declared final173
Parameter 'routes' is not assigned and could be declared final179
Parameter 'msg' is not assigned and could be declared final197
Local variable could be declared final207
Local variable could be declared final208 - 212
Parameter 'info' is not assigned and could be declared final222
Parameter 'head' is not assigned and could be declared final222

triptracker/client/gps/ui/GPSClient.java

ViolationLine
Parameter 'args' is not assigned and could be declared final32
System.out.print is used33
System.out.print is used34
Local variable could be declared final36
Local variable could be declared final38
Local variable could be declared final40
System.out.print is used44
Local variable could be declared final48
Local variable could be declared final49

triptracker/client/gps/ui/MainForm.java

ViolationLine
Parameter 'listener' is not assigned and could be declared final175
Parameter 'listener' is not assigned and could be declared final184
Parameter 'listener' is not assigned and could be declared final193
Parameter 'listener' is not assigned and could be declared final202
Parameter 'coord' is not assigned and could be declared final220
Local variable could be declared final228
System.out.print is used262
Parameter 'icon' is not assigned and could be declared final274
Parameter 'error' is not assigned and could be declared final274
Parameter 'heading' is not assigned and could be declared final274
Local variable could be declared final284
Local variable could be declared final285
Parameter 'status' is not assigned and could be declared final308
Parameter 'lat' is not assigned and could be declared final326
Parameter 'lon' is not assigned and could be declared final326
Parameter 'update' is not assigned and could be declared final336
Parameter 'state' is not assigned and could be declared final340
System.out.print is used344
System.out.print is used347
System.out.print is used351
System.out.print is used355
Parameter 'connected' is not assigned and could be declared final360
Parameter 'listener' is not assigned and could be declared final367
Parameter 'text' is not assigned and could be declared final376
Parameter 'text' is not assigned and could be declared final385
Parameter 'error' is not assigned and could be declared final402
Parameter 'heading' is not assigned and could be declared final402
Local variable could be declared final459
Local variable could be declared final460 - 463
Parameter 'route' is not assigned and could be declared final472
Parameter 'state' is not assigned and could be declared final477
Parameter 'e' is not assigned and could be declared final542
System.out.print is used544
Parameter 'dist' is not assigned and could be declared final552

triptracker/client/gps/ui/LoginController.java

ViolationLine
Parameter 'event' is not assigned and could be declared final45
Avoid printStackTrace(); use a logger call instead.70

triptracker/client/gps/ui/LoginForm.java

ViolationLine
The String literal "tab hfill" appears 4 times in this file; the first occurrence is on line 113113
Parameter 'listener' is not assigned and could be declared final144
Parameter 'msg' is not assigned and could be declared final186
Parameter 'state' is not assigned and could be declared final194
System.out.print is used204
Parameter 'warning' is not assigned and could be declared final241
Parameter 'heading' is not assigned and could be declared final241
Parameter 'enable' is not assigned and could be declared final257

triptracker/client/gps/ui/MainFormController.java

ViolationLine
Parameter 'event' is not assigned and could be declared final64
System.out.print is used84
Avoid using if...else statements without curly braces87
Avoid using if...else statements without curly braces89
Parameter 'event' is not assigned and could be declared final103
System.out.print is used106
Parameter 'e' is not assigned and could be declared final115
Avoid using if statements without curly braces176 - 177
Avoid using if statements without curly braces184 - 185
System.out.print is used200
Avoid using if statements without curly braces208 - 209

triptracker/client/gps/ui/GPSController.java

ViolationLine
Avoid using if statements without curly braces41 - 42
Parameter 'event' is not assigned and could be declared final50
Local variable could be declared final51
Avoid using if statements without curly braces81 - 82

triptracker/client/gps/ui/GPSSettingsForm.java

ViolationLine
The String literal "center" appears 5 times in this file; the first occurrence is on line 106106
Parameter 'listener' is not assigned and could be declared final135
Local variable could be declared final156
System.out.print is used159
Parameter 'msg' is not assigned and could be declared final196

triptracker/client/map/core/AbstractMapProvider.java

ViolationLine
Parameter 'width' is not assigned and could be declared final46
Parameter 'height' is not assigned and could be declared final46

triptracker/client/map/core/WMSMapProvider.java

ViolationLine
Parameter 'minY' is not assigned and could be declared final141
Parameter 'minX' is not assigned and could be declared final141
Parameter 'maxX' is not assigned and could be declared final142
Parameter 'maxY' is not assigned and could be declared final142
Local variable could be declared final155
System.out.print is used173
Avoid using if...else statements without curly braces177
Local variable could be declared final187
Parameter 'layers' is not assigned and could be declared final225
Parameter 'layerName' is not assigned and could be declared final229
Parameter 'layerName' is not assigned and could be declared final233
Parameter 'layerName' is not assigned and could be declared final237
Parameter 'styles' is not assigned and could be declared final244
Parameter 'styleName' is not assigned and could be declared final248
Parameter 'styleName' is not assigned and could be declared final252
Parameter 'styleName' is not assigned and could be declared final256
Parameter 'imageFormat' is not assigned and could be declared final268
Parameter 'providerUrl' is not assigned and could be declared final276
Parameter 'srs' is not assigned and could be declared final284
Parameter 'bgColor' is not assigned and could be declared final292
Parameter 'transparent' is not assigned and could be declared final300

triptracker/client/map/core/SimpleMatrixOps.java

ViolationLine
Parameter 'mat2' is not assigned and could be declared final148
Parameter 'mat1' is not assigned and could be declared final148
Avoid using if statements without curly braces152 - 153
Parameter 'factor' is not assigned and could be declared final175
Parameter 'matrix' is not assigned and could be declared final175
Parameter 'matrices' is not assigned and could be declared final209
Avoid using if statements without curly braces216 - 218
Parameter 'matrices' is not assigned and could be declared final235
Local variable could be declared final236 - 237
Avoid using if statements without curly braces242 - 244
Parameter 'layout' is not assigned and could be declared final266
Local variable could be declared final267 - 268
Parameter 'mat' is not assigned and could be declared final284
Parameter 'defaultValue' is not assigned and could be declared final285
Local variable could be declared final286 - 287
Local variable could be declared final288
Local variable could be declared final289
Parameter 'layout' is not assigned and could be declared final315
Avoid using if statements without curly braces326 - 327
Avoid using if statements without curly braces335 - 336
Avoid using if statements without curly braces344 - 345
Avoid using if statements without curly braces353 - 354

triptracker/client/map/core/Matrix2D.java

ViolationLine
The user-supplied array 'matrix' is stored directly35
Parameter 'matrix' is not assigned and could be declared final35
Returning 'mat' may expose an internal array40
Parameter 'i' is not assigned and could be declared final43
Parameter 'value' is not assigned and could be declared final43
Parameter 'j' is not assigned and could be declared final43
Parameter 'i' is not assigned and could be declared final47
Parameter 'j' is not assigned and could be declared final47
Parameter 'dimension' is not assigned and could be declared final51
Local variable could be declared final92
Parameter 'o' is not assigned and could be declared final145
System.out.print is used146
Parameter 'o' is not assigned and could be declared final153
Parameter 'forward' is not assigned and could be declared final163

triptracker/client/map/core/MapCacheProvider.java

ViolationLine
Parameter 'minY' is not assigned and could be declared final43
Parameter 'minX' is not assigned and could be declared final43
Parameter 'maxX' is not assigned and could be declared final44
Parameter 'maxY' is not assigned and could be declared final44

triptracker/client/map/ui/ConfigController.java

ViolationLine
Parameter 'e' is not assigned and could be declared final57
Parameter 'e' is not assigned and could be declared final67
Parameter 'e' is not assigned and could be declared final80
Parameter 'e' is not assigned and could be declared final98
Avoid using if...else statements without curly braces105
Parameter 'e' is not assigned and could be declared final111
Parameter 'e' is not assigned and could be declared final117
Parameter 'e' is not assigned and could be declared final123
Parameter 'e' is not assigned and could be declared final129

triptracker/client/map/ui/MapController.java

ViolationLine
Parameter 'click' is not assigned and could be declared final43

triptracker/client/map/ui/TabbedForm.java

ViolationLine
Parameter 'route' is not assigned and could be declared final82
Parameter 'realtime' is not assigned and could be declared final82
Parameter 'user' is not assigned and could be declared final88
Parameter 'route' is not assigned and could be declared final88
Parameter 'coordList' is not assigned and could be declared final100
Parameter 'nr' is not assigned and could be declared final104
Parameter 'map' is not assigned and could be declared final104
Parameter 'dot' is not assigned and could be declared final104
Parameter 'thick' is not assigned and could be declared final104

triptracker/client/map/ui/MapViewPanel.java

ViolationLine
Avoid unused imports such as 'javax.swing.ImageIcon'35

triptracker/client/map/ui/LoginController.java

ViolationLine
Parameter 'e' is not assigned and could be declared final46
Local variable could be declared final47
Local variable could be declared final48

triptracker/client/map/ui/LoginForm.java

ViolationLine
Parameter 'listener' is not assigned and could be declared final105
Parameter 'msg' is not assigned and could be declared final125
Parameter 'e' is not assigned and could be declared final133
Parameter 'state' is not assigned and could be declared final141

triptracker/client/map/ui/MapViewController.java

ViolationLine
Avoid unused constructor parameters such as 'model'34 - 44
Parameter 'e' is not assigned and could be declared final47
Parameter 'e' is not assigned and could be declared final53
Parameter 'arg0' is not assigned and could be declared final59
Parameter 'arg0' is not assigned and could be declared final62
Parameter 'arg0' is not assigned and could be declared final63
Parameter 'arg0' is not assigned and could be declared final64
Parameter 'arg0' is not assigned and could be declared final65
Parameter 'arg0' is not assigned and could be declared final69
Parameter 'arg0' is not assigned and could be declared final72
Parameter 'arg0' is not assigned and could be declared final73
Parameter 'arg0' is not assigned and could be declared final74
Parameter 'arg0' is not assigned and could be declared final75
Parameter 'arg0' is not assigned and could be declared final80
Avoid using if...else statements without curly braces82
Avoid using if...else statements without curly braces84
Avoid using if...else statements without curly braces86
Parameter 'arg0' is not assigned and could be declared final91

triptracker/client/ui/AbstractFormManager.java

ViolationLine
Parameter 'form' is not assigned and could be declared final48
Parameter 'form' is not assigned and could be declared final60
Parameter 'form' is not assigned and could be declared final72

triptracker/client/ui/SwingWorker.java

ViolationLine
Avoid unused private fields such as 'thread'18
Parameter 'x' is not assigned and could be declared final44
Local variable could be declared final65
Local variable could be declared final79
Local variable could be declared final96
Local variable could be declared final141